Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 )
Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.h@417 PS1, Line 417: Set's nit: typo http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.h@442 PS1, Line 442: This timestamp must be within the : /// duration of statestore_heartbeat_log_frequency_seconds. needs more explanation. how about instead: " Is updated every "statestore_heartbeat_log_frequency_seconds" seconds with the last heartbeat. A timestamp much older than the update frequency implies an unresponsive subscriber. " http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.cc@390 PS1, Line 390: 60 FLAGS_statestore_heartbeat_log_frequency_seconds http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.cc@389 PS1, Line 389: // Ensure that the timestamp to be updated is greater than the current value stored. : // We can't guarantee that the difference is exactly 60 seconds because we are storing : // the heartbeat timestamp in seconds while the hearbeats are sent maybe instead of the comment, a dcheck for the following should be self explanatory. timestamp_seconds > (recent_heartbeat_timestamp_ + FLAGS_statestore_heartbeat_log_frequency_seconds) -- To view, visit http://gerrit.cloudera.org:8080/11052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754adccc4569e8219d5d01500cccdfc8782953f7 Gerrit-Change-Number: 11052 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Comment-Date: Fri, 27 Jul 2018 19:00:23 +0000 Gerrit-HasComments: Yes
