Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 )
Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11052/2/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/11052/2/be/src/statestore/statestore.h@442 PS2, Line 442: of the most recently > ... of the most recently logged heartbeat ... Done http://gerrit.cloudera.org:8080/#/c/11052/2/be/src/statestore/statestore.h@446 PS2, Line 446: recent_logged_heartbeat_ts_ > This name sounds kind of misleading. To be more accurate, isn't it the " mo Done http://gerrit.cloudera.org:8080/#/c/11052/2/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/11052/2/be/src/statestore/statestore.cc@77 PS2, Line 77: statestore_heartbeat_log_frequency_seconds > Just wondering if it's necessary to make this configurable. Are there scena Agreed. As discussed on the issue's JIRA, it seems like we might need to tune this number based on the size/health of the cluster. What would you suggest here? http://gerrit.cloudera.org:8080/#/c/11052/2/be/src/statestore/statestore.cc@389 PS2, Line 389: DCHECK > Use DCHECK_GT Done -- To view, visit http://gerrit.cloudera.org:8080/11052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754adccc4569e8219d5d01500cccdfc8782953f7 Gerrit-Change-Number: 11052 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Mon, 30 Jul 2018 20:24:31 +0000 Gerrit-HasComments: Yes
