Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11096
Change subject: IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank ...................................................................... IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank While Prepare()-ing a fragment instance, if we fail to initialize the runtime filter bank, we will exit FIS::Prepare() without acquiring a thread token (AcquireThreadToken()): FIS::Finalize() is called always regardless of whether the fragment instance succeeded or failed. And FIS::Finalize() tries to ReleaseThreadToken() even though it might not have gotten acquired, causing a DCHECK to be hit. This patch fixes it by making sure that no failable code is run before acquiring the thread token, thereby ensuring that the thread token is always acquired and thus avoiding the above crash. A test is added to confirm this as well. This test crashes without the code changes in this patch. Change-Id: I1d6e7afc18fe2f0e1e29d2bd8a5f804a78f7043a --- M be/src/runtime/fragment-instance-state.cc M tests/failure/test_failpoints.py 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/11096/1 -- To view, visit http://gerrit.cloudera.org:8080/11096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d6e7afc18fe2f0e1e29d2bd8a5f804a78f7043a Gerrit-Change-Number: 11096 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
