Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11096 )
Change subject: IMPALA-7376: DCHECK hit if a fragment instance fails to initialize the filter bank ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Carry +2. http://gerrit.cloudera.org:8080/#/c/11096/2/tests/failure/test_failpoints.py File tests/failure/test_failpoints.py: http://gerrit.cloudera.org:8080/#/c/11096/2/tests/failure/test_failpoints.py@147 PS2, Line 147: query_options={'debug_action':debug_action}) > Should we also verify that the query actually failed ? It is already doing that since the function called is: execute_query_expect_failure() -- To view, visit http://gerrit.cloudera.org:8080/11096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d6e7afc18fe2f0e1e29d2bd8a5f804a78f7043a Gerrit-Change-Number: 11096 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 01 Aug 2018 23:01:10 +0000 Gerrit-HasComments: Yes
