Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 )
Change subject: IMPALA-7317: loosen flake8 rules ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg File setup.cfg: http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg@19 PS1, Line 19: # E121,E127,E128: ignored to allow some of the more common idioms for multi-line statement : # indentation used in the Impala code. Excluding these leads to a broader interpretation of how Python whitespace should be applied and thus inconsistencies in style. I don't think keeping them enforced would produce an undue burden on submitters, because we are using --diff and not "punishing" a submitter for existing code that violates these. However, I won't block this if the community prefers. http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg@21 PS1, Line 21: # E701: ignored to allow if statement body on same line as conditional I can live with this, as PEP-008 doesn't forbid it outright. -- To view, visit http://gerrit.cloudera.org:8080/11102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaaa8377025e732231ac0f1f1f2db67298a171997 Gerrit-Change-Number: 11102 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 21:58:32 +0000 Gerrit-HasComments: Yes
