Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 )
Change subject: IMPALA-7317: loosen flake8 rules ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg File setup.cfg: http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg@23 PS1, Line 23: ignore = E111,E114,E121,E128,E701 > I'm not sure the "wrong" example is really wrong, at least according to fla It sounds as if we agree that by choosing 2-space indents, we've confused the tool. However, it is possible to make the tool happy without exclusions. That is what I was trying to point out. -- To view, visit http://gerrit.cloudera.org:8080/11102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaaa8377025e732231ac0f1f1f2db67298a171997 Gerrit-Change-Number: 11102 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 01 Aug 2018 22:20:37 +0000 Gerrit-HasComments: Yes
