Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11103 )
Change subject: IMPALA-7096: restore scanner thread memory heuristics ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11103/4/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11103/4/be/src/exec/hdfs-scan-node.cc@59 PS4, Line 59: const int SCANNER_THREAD_MEM_USAGE = 32 * 1024 * 1024; Make configurable? http://gerrit.cloudera.org:8080/#/c/11103/4/be/src/runtime/scanner-mem-limiter.h File be/src/runtime/scanner-mem-limiter.h: http://gerrit.cloudera.org:8080/#/c/11103/4/be/src/runtime/scanner-mem-limiter.h@26 PS4, Line 26: #include "common/atomic.h" Not needed -- To view, visit http://gerrit.cloudera.org:8080/11103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9907fa8c4d2b0b85f67f4f160899c1c258ad82b Gerrit-Change-Number: 11103 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 03 Aug 2018 15:43:38 +0000 Gerrit-HasComments: Yes
