Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11103 )
Change subject: IMPALA-7096: restore scanner thread memory heuristics ...................................................................... Patch Set 6: Code-Review+1 (5 comments) looks good. just a few mits http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/exec/hdfs-scan-node.cc@55 PS6, Line 55: he nit: The http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/exec/kudu-scan-node.h File be/src/exec/kudu-scan-node.h: http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/exec/kudu-scan-node.h@77 PS6, Line 77: GetEstimatedMemPerThread nit: maybe have the same name here as in hdfs-scan node http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/exec/kudu-scan-node.cc@159 PS6, Line 159: / Cases 5, 6 and 7. nit: copy-paste error http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/runtime/scanner-mem-limiter.h File be/src/runtime/scanner-mem-limiter.h: http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/runtime/scanner-mem-limiter.h@30 PS6, Line 30: /// Class to keep track of the global state of scanner threads and how much memory nit: I know its implied, but maybe just mention explicitly that it is used to keep track of the scanner threads on a per query per host level. The first time i read it, without looking at the whole patch it seemed like it kept track of all scanner threads running on the host. http://gerrit.cloudera.org:8080/#/c/11103/6/be/src/runtime/scanner-mem-limiter.h@42 PS6, Line 42: Each 'node' can only be registered once. maybe add a dcheck for that -- To view, visit http://gerrit.cloudera.org:8080/11103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9907fa8c4d2b0b85f67f4f160899c1c258ad82b Gerrit-Change-Number: 11103 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 21:23:10 +0000 Gerrit-HasComments: Yes
