Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11087 )
Change subject: IMPALA-7354: planner test resource estimates for more workloads ...................................................................... Patch Set 5: (2 comments) looks fine... I have one clarifying question. http://gerrit.cloudera.org:8080/#/c/11087/5/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/11087/5/fe/src/main/java/org/apache/impala/planner/Planner.java@273 PS5, Line 273: printBytes just wondering why this one is not changed as well? http://gerrit.cloudera.org:8080/#/c/11087/5/testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test: http://gerrit.cloudera.org:8080/#/c/11087/5/testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test@25 PS5, Line 25: 66.00MB Threads=2 : Per-Host Resource Estimates: Memory=744MB this seems odd: decimal places for memory reservation but not for estimates. -- To view, visit http://gerrit.cloudera.org:8080/11087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9f836699200ea87fb03bf36abad0e23949ac26 Gerrit-Change-Number: 11087 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 03 Aug 2018 22:24:57 +0000 Gerrit-HasComments: Yes
