Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11087 )
Change subject: IMPALA-7354: planner test resource estimates for more workloads ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11087/5/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/11087/5/fe/src/main/java/org/apache/impala/planner/Planner.java@273 PS5, Line 273: printBytes > just wondering why this one is not changed as well? My thought was that the reservation is a precise number (if the query gets any less than this, it will fail) but the estimate is an imprecise number. I was thinking that the extra precision lets planner tests catch smaller errors in the calculations. On the other hand, sub-megabyte precision isn't informative for users and we still expose and verify it at higher explain levels at plan and fragment levels: https://github.com/apache/impala/blob/master/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test#L8 So I could go either way. Given that it jumped out at you, maybe users will find the inconsistency confusing. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/11087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9f836699200ea87fb03bf36abad0e23949ac26 Gerrit-Change-Number: 11087 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 03 Aug 2018 22:46:19 +0000 Gerrit-HasComments: Yes
