Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11119 )
Change subject: IMPALA-6789: disable impersonate in hive in minicluster ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11119/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/11119/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@963 PS1, Line 963: `%s` > Why this? Do you have some usernames that conflict with keywords or somethi Sorry that I only mentioned this in the commit message. My username is quanlong.huang which will have syntax error if the name is not quoted. The DOT in the name is the cause. http://gerrit.cloudera.org:8080/#/c/11119/1/fe/src/test/resources/postgresql-hive-site.xml.template File fe/src/test/resources/postgresql-hive-site.xml.template: http://gerrit.cloudera.org:8080/#/c/11119/1/fe/src/test/resources/postgresql-hive-site.xml.template@145 PS1, Line 145: <property> : <name>hive.server2.enable.impersonation</name> : <description>Enable user impersonation for HiveServer2</description> : <value>true</value> : </property> > This looks the same. Is it deprecated in favor of doAs? If so, this should Yes, according to https://github.com/cloudera/hive/commit/1cac04b0e739019b9da99fe916e2fe5497c4abb8 , this is the old name of hive.server2.enable.doAs http://gerrit.cloudera.org:8080/#/c/11119/1/fe/src/test/resources/postgresql-hive-site.xml.template@198 PS1, Line 198: <property> : <name>hive.server2.enable.doAs</name> : <value>false</value> : </property> > Can you add a comment as to why we are explicitly disabling this. Done -- To view, visit http://gerrit.cloudera.org:8080/11119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 11119 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 04 Aug 2018 00:58:28 +0000 Gerrit-HasComments: Yes
