Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11119 )

Change subject: IMPALA-6789: disable impersonate in hive in minicluster
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

Patch lgtm. I'll let Phil take a pass since he helped you root cause this.

http://gerrit.cloudera.org:8080/#/c/11119/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11119/2//COMMIT_MSG@7
PS2, Line 7: impersonate
nit: impersonation


http://gerrit.cloudera.org:8080/#/c/11119/2//COMMIT_MSG@11
PS2, Line 11: impersonate
same


http://gerrit.cloudera.org:8080/#/c/11119/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java:

http://gerrit.cloudera.org:8080/#/c/11119/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@963
PS1, Line 963: `%s`
> Sorry that I only mentioned this in the commit message. My username is quan
Ah ok. Is this the only test that is broken due to this? Wondering if there are 
other places that need some fixing.



-- 
To view, visit http://gerrit.cloudera.org:8080/11119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a
Gerrit-Change-Number: 11119
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Sat, 04 Aug 2018 01:34:32 +0000
Gerrit-HasComments: Yes

Reply via email to