Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11039 )

Change subject: IMPALA-7342: Add initial support for user-level permissions
......................................................................


Patch Set 14:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java
File fe/src/main/java/org/apache/impala/util/SentryProxy.java:

http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@257
PS14, Line 257:   public synchronized Principal dropRole(User user, String 
roleName) throws ImpalaException {
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@269
PS14, Line 269:   public synchronized Principal grantRoleGroup(User user, 
String roleName, String groupName)
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@282
PS14, Line 282:   public synchronized Principal revokeRoleGroup(User user, 
String roleName, String groupName)
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@333
PS14, Line 333:         PrincipalPrivilege existingPriv = 
catalog_.getPrincipalPrivilege(roleName, privilege);
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/11039
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f
Gerrit-Change-Number: 11039
Gerrit-PatchSet: 14
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Adam Holley <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Sun, 05 Aug 2018 04:25:31 +0000
Gerrit-HasComments: Yes

Reply via email to