Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 )
Change subject: IMPALA-7342: Add initial support for user-level permissions ...................................................................... Patch Set 15: Code-Review+1 (3 comments) Fixed formatting and carry Adam's +1. http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@257 PS14, Line 257: public synchronized Principal dropRole(User user, String roleName) > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@269 PS14, Line 269: */ > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/11039/14/fe/src/main/java/org/apache/impala/util/SentryProxy.java@282 PS14, Line 282: */ > line too long (93 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 15 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Sun, 05 Aug 2018 04:29:59 +0000 Gerrit-HasComments: Yes
