Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11119 )
Change subject: IMPALA-6789: disable impersonation in hive in minicluster ...................................................................... Patch Set 4: Code-Review+2 Seems fine. This only affects our Hive server configuration, which really only affects data load, so I don't think it's problematic. Fixing the underlying Hadoop issue (https://issues.apache.org/jira/browse/HADOOP-7050) by fixing the parsing of some files was also possible, but I accept that this was easier :) In terms of adding a Jenkins job for this, the cheapest way I know is to change "test-with-docker" to have different possibly usernames. Or to run Jenkins workers with different users. Both of those things currently seem to me like more work than it's worth. (In part, such a test would be testing our tests; our product doesn't see this.) -- To view, visit http://gerrit.cloudera.org:8080/11119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39d8945e0fe90baf7e9e4b26eebab08d2058a14a Gerrit-Change-Number: 11119 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 16:26:35 +0000 Gerrit-HasComments: No
