Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10970 )
Change subject: IMPALA-7308. Support Avro tables in LocalCatalog ...................................................................... Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10970/7/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10970/7/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@329 PS7, Line 329: for (FeFsPartition p : partitions) { clarifying question: since the list of partitions that are loaded is partial, the result from this method will depend on the subset that's loaded, correct? so if the user is in the case where the table is not an avro schema, but some partition has an avro schema, they may or may not see an error due to incompatible schemas (on read). If that's the case, the impact of the difference in behavior may even be less. -- To view, visit http://gerrit.cloudera.org:8080/10970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69 Gerrit-Change-Number: 10970 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 19:00:08 +0000 Gerrit-HasComments: Yes
