Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10970 )
Change subject: IMPALA-7308. Support Avro tables in LocalCatalog ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/10970/7/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10970/7/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@329 PS7, Line 329: for (FeFsPartition p : partitions) { > clarifying question: since the list of partitions that are loaded is partia right. This code is just used to determine whether to bother sending any avro schema in the descriptor. (If there is no Avro partition included in the descriptor, there is no reason to bother sending it). So, in that case, even if it's an incompatible schema, if you aren't querying any avro partitions, it won't matter. It's only if it's incompatible _and_ you query such a partition that you'd get an error. -- To view, visit http://gerrit.cloudera.org:8080/10970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69 Gerrit-Change-Number: 10970 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 07:07:40 +0000 Gerrit-HasComments: Yes
