Tim Armstrong has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with
--thread_creation_fault_injection
......................................................................
IMPALA-7396: unblock testing with --thread_creation_fault_injection
These are minimal fixes to allow testing new patches with the fault
injection.
ClientRequestState: fixing this seems somewhat involved, so disabled the
fault injection for now to unblock further testing.
HdfsScanNode: thread_state_.DecrementNumActive() was called on the error
path before the count had actually been incremented.
Testing:
Ran some of the end-to-end tests for 20-30 minutes and confirmed that
no Impalads crashed.
start-impala-cluster.py \
--impalad_args=--thread_creation_fault_injection=true
impala-py.test tests/query_test/*.py -n2 --verbose
Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Reviewed-on: http://gerrit.cloudera.org:8080/11123
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Tim Armstrong <[email protected]>
---
M be/src/exec/hdfs-scan-node.cc
M be/src/service/client-request-state.cc
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Gerrit-Change-Number: 11123
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
