Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11123 )
Change subject: IMPALA-7396: unblock testing with --thread_creation_fault_injection ...................................................................... Patch Set 5: > There were at least two layers: > 1. The Coordinator was not in a terminal state, so it DCHECKed in > the destructor. > 2. I tried a few things to avoid that, including disabling the > DCHECK and cancelling the query, but I still ended up hitting > various lifecycle issues, e.g. backend_exec_complete_barrier_ was > NULL. Is there a JIRA for fixing those (don't see it linked to IMPALA-7396)? -- To view, visit http://gerrit.cloudera.org:8080/11123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7 Gerrit-Change-Number: 11123 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 23:43:01 +0000 Gerrit-HasComments: No
