Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 )
Change subject: IMPALA-110: Support for multiple DISTINCT ...................................................................... Patch Set 3: (23 comments) http://gerrit.cloudera.org:8080/#/c/10771/3/be/src/codegen/gen_ir_descriptions.py File be/src/codegen/gen_ir_descriptions.py: http://gerrit.cloudera.org:8080/#/c/10771/3/be/src/codegen/gen_ir_descriptions.py@55 PS3, Line 55: o flake8: E501 line too long (125 > 90 characters) http://gerrit.cloudera.org:8080/#/c/10771/3/be/src/exec/aggregation-node-base.h File be/src/exec/aggregation-node-base.h: http://gerrit.cloudera.org:8080/#/c/10771/3/be/src/exec/aggregation-node-base.h@32 PS3, Line 32: AggregationNodeBase(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl& descs); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/be/src/exec/aggregation-node-base.h@56 PS3, Line 56: Status SplitMiniBatches(RowBatch* batch, std::vector<std::unique_ptr<RowBatch>>* mini_batches); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/be/src/exec/aggregation-node-base.cc File be/src/exec/aggregation-node-base.cc: http://gerrit.cloudera.org:8080/#/c/10771/3/be/src/exec/aggregation-node-base.cc@77 PS3, Line 77: Status AggregationNodeBase::SplitMiniBatches(RowBatch* batch, vector<unique_ptr<RowBatch>>* mini_batches) { line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@351 PS3, Line 351: AggregateInfo result = AggregateInfo.create(transGroupingExprs, transAggExprs, analyzer); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@509 PS3, Line 509: rhsExprs.add(new SlotRef(matAggClassTupleDesc.getSlots().get(numGroupingExprs + idx))); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@645 PS3, Line 645: public AggregateInfo getMaterializedAggClass(int i) { return materializedAggInfos_.get(i); } line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@659 PS3, Line 659: if (stmt.hasLimit() && (!(expr instanceof BinaryPredicate) || !stmt.hasMultiAggInfo() || line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@345 PS3, Line 345: "11AggIfUpdateIN10impala_udf10BooleanValEEEvPNS2_15FunctionContextERKS3_RKT_PS8_") line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@347 PS3, Line 347: "11AggIfUpdateIN10impala_udf10TinyIntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@349 PS3, Line 349: "11AggIfUpdateIN10impala_udf11SmallIntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@351 PS3, Line 351: "11AggIfUpdateIN10impala_udf6IntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@353 PS3, Line 353: "11AggIfUpdateIN10impala_udf9BigIntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@355 PS3, Line 355: "11AggIfUpdateIN10impala_udf8FloatValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@357 PS3, Line 357: "11AggIfUpdateIN10impala_udf9DoubleValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@359 PS3, Line 359: "11AggIfUpdateIN10impala_udf9StringValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@361 PS3, Line 361: "11AggIfUpdateIN10impala_udf12TimestampValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@363 PS3, Line 363: "11AggIfUpdateIN10impala_udf10DecimalValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@409 PS3, Line 409: "13AggIfFinalizeIN10impala_udf12TimestampValEEET_PNS2_15FunctionContextERKS4_") line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@909 PS3, Line 909: DataPartition phase1MergePartition = DataPartition.hashPartitioned(phase1PartitionExprs); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@914 PS3, Line 914: new AggregationNode(ctx_.getNextNodeId(), phase1AggNode, phase1AggNode.getMultiAggInfo(), line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@936 PS3, Line 936: List<Expr> phase2PartitionExprs = phase2AggNode.getMergePartitionExprs(ctx_.getRootAnalyzer()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/10771/3/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@631 PS3, Line 631: scanAggInfo.getMergeAggInfo().substitute(((HdfsScanNode) root).getOptimizedAggSmap(), analyzer); line too long (104 > 90) -- To view, visit http://gerrit.cloudera.org:8080/10771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055402eaef6d81e5f70e850d9f8a621e766830a4 Gerrit-Change-Number: 10771 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 17:09:59 +0000 Gerrit-HasComments: Yes
