Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 )
Change subject: IMPALA-110: Support for multiple DISTINCT ...................................................................... Patch Set 4: (13 comments) http://gerrit.cloudera.org:8080/#/c/10771/4/be/src/codegen/gen_ir_descriptions.py File be/src/codegen/gen_ir_descriptions.py: http://gerrit.cloudera.org:8080/#/c/10771/4/be/src/codegen/gen_ir_descriptions.py@55 PS4, Line 55: o flake8: E501 line too long (125 > 90 characters) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@646 PS4, Line 646: public AggregateInfo getMaterializedAggClass(int i) { return materializedAggInfos_.get(i); } line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@345 PS4, Line 345: "11AggIfUpdateIN10impala_udf10BooleanValEEEvPNS2_15FunctionContextERKS3_RKT_PS8_") line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@347 PS4, Line 347: "11AggIfUpdateIN10impala_udf10TinyIntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@349 PS4, Line 349: "11AggIfUpdateIN10impala_udf11SmallIntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@351 PS4, Line 351: "11AggIfUpdateIN10impala_udf6IntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@353 PS4, Line 353: "11AggIfUpdateIN10impala_udf9BigIntValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@355 PS4, Line 355: "11AggIfUpdateIN10impala_udf8FloatValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@357 PS4, Line 357: "11AggIfUpdateIN10impala_udf9DoubleValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@359 PS4, Line 359: "11AggIfUpdateIN10impala_udf9StringValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@361 PS4, Line 361: "11AggIfUpdateIN10impala_udf12TimestampValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@363 PS4, Line 363: "11AggIfUpdateIN10impala_udf10DecimalValEEEvPNS2_15FunctionContextERKNS2_10BooleanValERKT_PS9_") line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/10771/4/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@409 PS4, Line 409: "13AggIfFinalizeIN10impala_udf12TimestampValEEET_PNS2_15FunctionContextERKS4_") line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/10771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055402eaef6d81e5f70e850d9f8a621e766830a4 Gerrit-Change-Number: 10771 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 17:55:38 +0000 Gerrit-HasComments: Yes
