Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 )
Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11052/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11052/5//COMMIT_MSG@16 PS5, Line 16: Testing: Manually inspected the Web UI and statestore logs to : verify that the last heartbeat timestamp for each subscriber is : updated periodically. sorry, one more thing I forgot to mention: can we add an automated e2e test to test_statestore.py that ensures that this data shows up and is reasonable? If you want to get fancy you could even kill -STOP one of the subscribers and make sure that it eventually shows up as inactive, but I'd be OK if you just do the basic thing of checking that some reasonable looking strings show up in the JSON. -- To view, visit http://gerrit.cloudera.org:8080/11052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754adccc4569e8219d5d01500cccdfc8782953f7 Gerrit-Change-Number: 11052 Gerrit-PatchSet: 5 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 08 Aug 2018 00:50:12 +0000 Gerrit-HasComments: Yes
