Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11174 )
Change subject: IMPALA-7335: Add logs HdfsScanNode to debug the issue ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Looks good to me! @Tim can you +2 if you dont see any major concerns? http://gerrit.cloudera.org:8080/#/c/11174/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11174/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-7335: Add logs HdfsScanNode to debug the issue : : This log would help determine the condition when the test failures : occur. could you add some more details to the log message. See https://gerrit.cloudera.org/#/c/10851/ for some reference http://gerrit.cloudera.org:8080/#/c/11174/5/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/11174/5/be/src/exec/hdfs-scan-node.cc@333 PS5, Line 333: #ifndef NDEBUG : VLOG_QUERY << "Non-ok status returned by ProcessSplit = " << status.msg().msg() : << " for Scan node (id=" << id() : << ", status_ = " << (status_.ok() ? "ok" : status_.msg().msg()) : << ", done_ = " << (done_ ? "1" : "0") << ")"; : #endif if you plan to remove this after you figure out the cause, you can add a TODO here, with the JIRA ID so it doesnt get unnoticed. -- To view, visit http://gerrit.cloudera.org:8080/11174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1 Gerrit-Change-Number: 11174 Gerrit-PatchSet: 5 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 10 Aug 2018 23:07:30 +0000 Gerrit-HasComments: Yes
