Pooja Nilangekar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11174 )

Change subject: IMPALA-7335/IMPALA-7418: Add logs to HdfsScanNode to debug the 
issues
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

Carrying forward Bikram's +1.

http://gerrit.cloudera.org:8080/#/c/11174/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11174/5//COMMIT_MSG@7
PS5, Line 7: IMPALA-7335/IMPALA-7418: Add logs to HdfsScanNode to debug the 
issues
           :
           : IMPALA-7335 and IMPALA-7418 are failing some builds on jenkins.
           : Howeve
> could you add some more details to the log message. See https://gerrit.clou
Done


http://gerrit.cloudera.org:8080/#/c/11174/5/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

http://gerrit.cloudera.org:8080/#/c/11174/5/be/src/exec/hdfs-scan-node.cc@333
PS5, Line 333: #ifndef NDEBUG
             :       // TODO (IMPALA-7430): Remove the log message once the 
causes of IMPALA-7335 and
             :       // IMPALA-7418 are determined.
             :       VLOG_QUERY << "Non-ok status returned by ProcessSplit = " 
<< status.msg().msg()
             :                  << " for Scan node (id=" << id()
             :
> if you plan to remove this after you figure out the cause, you can add a TO
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Gerrit-Change-Number: 11174
Gerrit-PatchSet: 6
Gerrit-Owner: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Mon, 13 Aug 2018 18:20:53 +0000
Gerrit-HasComments: Yes

Reply via email to