Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11205 )

Change subject: IMPALA-7356 (part 1 of ?): admission control stress
......................................................................


Patch Set 5:

(1 comment)

Seems fine and straightforward, just one usability question below.

http://gerrit.cloudera.org:8080/#/c/11205/5/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:

http://gerrit.cloudera.org:8080/#/c/11205/5/tests/stress/concurrent_select.py@450
PS5, Line 450: "AC Reject", "AC Timeout",
Do you have thoughts on always printing these columns vs. only printing these 
columns when --test-admission-control=true ?



--
To view, visit http://gerrit.cloudera.org:8080/11205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id31a77f1fe6854a56ce54d1de333793e18087be4
Gerrit-Change-Number: 11205
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 14 Aug 2018 17:07:11 +0000
Gerrit-HasComments: Yes

Reply via email to