Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11205 )
Change subject: IMPALA-7356 (part 1 of ?): admission control stress ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11205/5/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: http://gerrit.cloudera.org:8080/#/c/11205/5/tests/stress/concurrent_select.py@450 PS5, Line 450: "AC Reject", "AC Timeout", > Do you have thoughts on always printing these columns vs. only printing the I thought about that too. I decided not to handle that case separately, partly because it makes the logic simpler and partly because if, hypothetically, we ran against a cluster with AC enabled but --test-admission-control=false, I don't think we'd want to count the rejections as a test failure. It does add even more noise to the display though - it feels like we should be able to do something better than the scrolling columns -- To view, visit http://gerrit.cloudera.org:8080/11205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id31a77f1fe6854a56ce54d1de333793e18087be4 Gerrit-Change-Number: 11205 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 18:00:36 +0000 Gerrit-HasComments: Yes
