Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11206 )
Change subject: IMPALA-5937: [DOCS] Documented enable_expr_rewrites query option ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11206/2/docs/topics/impala_enable_expr_rewrites.xml File docs/topics/impala_enable_expr_rewrites.xml: http://gerrit.cloudera.org:8080/#/c/11206/2/docs/topics/impala_enable_expr_rewrites.xml@39 PS2, Line 39: These optimizations walk through the expression trees and : rewrite them if they have constants that can be evaluated during query : analysis and replace them with evaluated expressions, removing the need to : evaluate them during runtime > Removed this, wondering do we need to provide this much detail to customers IMO, we should have some detail, otherwise the content as such does not make much sense. Maybe something like, These are query compile time optimizations that rewrite the expression trees to a more compact and optimized form that helps avoid redundant expression evaluation at run time. May not be phrased correctly but I hope you get the point :-) What do you think? -- To view, visit http://gerrit.cloudera.org:8080/11206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82a27172a6a6570f9c3cebe1a516a29c755e6d58 Gerrit-Change-Number: 11206 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 20:39:13 +0000 Gerrit-HasComments: Yes
