Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11206 )
Change subject: IMPALA-5937: [DOCS] Documented ENABLE_EXPR_REWRITES query option ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11206/2/docs/topics/impala_enable_expr_rewrites.xml File docs/topics/impala_enable_expr_rewrites.xml: http://gerrit.cloudera.org:8080/#/c/11206/2/docs/topics/impala_enable_expr_rewrites.xml@39 PS2, Line 39: These optimizations walk through the expression trees and : rewrite them if they have constants that can be evaluated during query : analysis and replace them with evaluated expressions, removing the need to : evaluate them during runtime > IMO, we should have some detail, otherwise the content as such does not mak Done http://gerrit.cloudera.org:8080/#/c/11206/3/docs/topics/impala_enable_expr_rewrites.xml File docs/topics/impala_enable_expr_rewrites.xml: http://gerrit.cloudera.org:8080/#/c/11206/3/docs/topics/impala_enable_expr_rewrites.xml@79 PS3, Line 79: > I'm confused whether this should be 2.8 or 2.9. Like I mentioned, the query Changed to 2.8 since this is version the option was added -- To view, visit http://gerrit.cloudera.org:8080/11206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82a27172a6a6570f9c3cebe1a516a29c755e6d58 Gerrit-Change-Number: 11206 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Tue, 14 Aug 2018 21:11:10 +0000 Gerrit-HasComments: Yes
