Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 )
Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11255/3/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11255/3/tests/shell/test_shell_commandline.py@344 PS3, Line 344: > It no longer relies on timeouts and should never be flaky any more. Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/11255/4/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/11255/4/tests/shell/util.py@140 PS4, Line 140: mathod nit: typo -- To view, visit http://gerrit.cloudera.org:8080/11255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65302ffb838d5185f77853bc2e53296f3a701d93 Gerrit-Change-Number: 11255 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Fri, 17 Aug 2018 19:59:37 +0000 Gerrit-HasComments: Yes
