Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11255 )
Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt ...................................................................... IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt test_cancellation runs a shell process, executes a query, sleeps, sends a sigint to the process, and then checks that the query is cancelled. If the sigint is sent prior to the shell installing its signal handler, the test can fail with a KeyboardInterrupt. This patch removes the reliance on the sleep being long enough by actually reading the output of the shell and only cancelling the query once the shell shows that it has started running. Testing: - Ran test_cancellation in a loop. Change-Id: I65302ffb838d5185f77853bc2e53296f3a701d93 Reviewed-on: http://gerrit.cloudera.org:8080/11255 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Thomas Marshall <[email protected]> --- M tests/shell/test_shell_commandline.py M tests/shell/util.py 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Thomas Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I65302ffb838d5185f77853bc2e53296f3a701d93 Gerrit-Change-Number: 11255 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]>
