Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11270 )
Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() ...................................................................... Patch Set 2: (1 comment) Thanks for the explanation. Seems good aside from a stale comment. http://gerrit.cloudera.org:8080/#/c/11270/2/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/11270/2/be/src/runtime/query-state.h@344 PS2, Line 344: instances_prepare_promise_ This variable doesn't exist. -- To view, visit http://gerrit.cloudera.org:8080/11270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35f2a5b0ea5143703850ffc229cec0e4294e6a3e Gerrit-Change-Number: 11270 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 20 Aug 2018 21:06:42 +0000 Gerrit-HasComments: Yes
