Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11270 )
Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11270/2/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/11270/2/be/src/runtime/query-state.h@344 PS2, Line 344: instances_prepare_promise_ > This variable doesn't exist. Fixed. http://gerrit.cloudera.org:8080/#/c/11270/2/be/src/runtime/query-state.h@345 PS2, Line 345: accessor > reader? Since writes by the startup thread are allowed, and in fact require Yes, was following the terminology accessor/mutator. Using the term "readers" make it clearer. http://gerrit.cloudera.org:8080/#/c/11270/2/be/src/runtime/query-state.h@351 PS2, Line 351: accessor > readers Done -- To view, visit http://gerrit.cloudera.org:8080/11270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35f2a5b0ea5143703850ffc229cec0e4294e6a3e Gerrit-Change-Number: 11270 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 20 Aug 2018 22:05:10 +0000 Gerrit-HasComments: Yes
