Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 )
Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/common/init.cc@179 PS10, Line 179: : nit: space on wrong side of : You could also simplify to "Sender UID: root, PID: 1234" http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/common/init.cc@297 PS10, Line 297: sigaction(SIGTERM, &action, nullptr); We should at least check the return value here. We also should pass an empty struct sigaction *oldact and verify that there was no other signal handler present. http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/util/minidump.cc File be/src/util/minidump.cc: http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/util/minidump.cc@102 PS10, Line 102: : nit: whitespace, see comment on other location http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/util/minidump.cc@119 PS10, Line 119: sigaction(SIGUSR1, &sig_action, NULL); While you're here, maybe check the return value to make sure this was successful, and pass struct sigaction *oldact to make sure we didn't overwrite any other handlers? -- To view, visit http://gerrit.cloudera.org:8080/10847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20da9e30440b7348557beccb8a0da14775fcc29 Gerrit-Change-Number: 10847 Gerrit-PatchSet: 10 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Mon, 20 Aug 2018 22:41:31 +0000 Gerrit-HasComments: Yes
