Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 )
Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/10847/10/be/src/common/init.cc@297 PS10, Line 297: if (sigaction(SIGTERM, &action, nullptr) == -1) { > There is a value 1 displayed for old_action.sa_handler ... Where is it displayed? Should we validate that it's this value then? http://gerrit.cloudera.org:8080/#/c/10847/12/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/10847/12/be/src/common/init.cc@298 PS12, Line 298: " > Should we also print the error itself then, e.g. using GetStrErrMsg()? Ping? -- To view, visit http://gerrit.cloudera.org:8080/10847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20da9e30440b7348557beccb8a0da14775fcc29 Gerrit-Change-Number: 10847 Gerrit-PatchSet: 12 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 16:19:23 +0000 Gerrit-HasComments: Yes
