Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 )
Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11279/1/fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java: http://gerrit.cloudera.org:8080/#/c/11279/1/fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java@22 PS1, Line 22: import org.apache.impala.authorization.PrivilegeRequestBuilder; unused import http://gerrit.cloudera.org:8080/#/c/11279/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/11279/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1972 PS1, Line 1972: test.ok(onServer(true, TPrivilegeLevel.ALL)) : .ok(onServer(true, TPrivilegeLevel.OWNER)) : .ok(onDatabase(true, "functional", TPrivilegeLevel.ALL)) : .ok(onDatabase(true, "functional", TPrivilegeLevel.OWNER)) : .ok(onTable(true, "functional", "alltypes", TPrivilegeLevel.ALL)) : .ok(onTable(true, "functional", "alltypes", TPrivilegeLevel.OWNER)) Should have failure tests for grant option false. http://gerrit.cloudera.org:8080/#/c/11279/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1985 PS1, Line 1985: nit: This indent is inconsistent with others. See previous test block. http://gerrit.cloudera.org:8080/#/c/11279/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2188 PS1, Line 2188: test.ok(onServer(true, TPrivilegeLevel.ALL)) : .ok(onServer(true, TPrivilegeLevel.OWNER)) : .ok(onDatabase(true, "functional", TPrivilegeLevel.ALL)) : .ok(onDatabase(true, "functional", TPrivilegeLevel.OWNER)) : .ok(onTable(true, "functional", "alltypes_view", TPrivilegeLevel.ALL)) : .ok(onTable(true, "functional", "alltypes_view", TPrivilegeLevel.OWNER)) Should have error tests for grant option false;. http://gerrit.cloudera.org:8080/#/c/11279/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2223 PS1, Line 2223: .ok(onServer(true, TPrivilegeLevel.ALL)) : .ok(onServer(true, TPrivilegeLevel.OWNER)) : .ok(onDatabase(true, "functional", TPrivilegeLevel.ALL)) : .ok(onDatabase(true, "functional", TPrivilegeLevel.OWNER)) Should have error tests for grant option false;. -- To view, visit http://gerrit.cloudera.org:8080/11279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2485933c02b5384950b7c882ba1eb0fd703db5a3 Gerrit-Change-Number: 11279 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 21 Aug 2018 05:50:29 +0000 Gerrit-HasComments: Yes
