Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 )
Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11279/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/11279/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1978 PS2, Line 1978: TPrivilegeLevel.ALL Can you reduce the number of lines by just using onServer(ALL_PRIVILEGES) similar to the allExcept pattern? This would apply to all the grantoption=false error cases. While unlikely, I don't see a case for ALTER without grant. -- To view, visit http://gerrit.cloudera.org:8080/11279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2485933c02b5384950b7c882ba1eb0fd703db5a3 Gerrit-Change-Number: 11279 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 21 Aug 2018 13:51:33 +0000 Gerrit-HasComments: Yes
