Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 )
Change subject: IMPALA-6373: Allow primitive type widening on parquet tables ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/11268/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11268/1//COMMIT_MSG@12 PS1, Line 12: tinyint > I think that it would be useful to mention that tinyint/smallint/int are al Done http://gerrit.cloudera.org:8080/#/c/11268/1/be/src/exec/parquet-common.h File be/src/exec/parquet-common.h: http://gerrit.cloudera.org:8080/#/c/11268/1/be/src/exec/parquet-common.h@260 PS1, Line 260: return byte_size; > Decode() should return the number of bytes read from the original buffer, s Thanks for the explanation! I got confused for a while when looking at the existing tests. Done. http://gerrit.cloudera.org:8080/#/c/11268/1/be/src/exec/parquet-common.h@271 PS1, Line 271: byte_siz > Same as line 260. Done http://gerrit.cloudera.org:8080/#/c/11268/1/be/src/exec/parquet-common.h@282 PS1, Line 282: return byte_size; > Same as line 260. Done http://gerrit.cloudera.org:8080/#/c/11268/1/be/src/exec/parquet-plain-test.cc File be/src/exec/parquet-plain-test.cc: http://gerrit.cloudera.org:8080/#/c/11268/1/be/src/exec/parquet-plain-test.cc@113 PS1, Line 113: int decoded_size = ParquetPlainEncoder::Decode<WidenInternalType, PARQUET_TYPE>( > This function should return the encoded size. Done http://gerrit.cloudera.org:8080/#/c/11268/1/be/src/exec/parquet-plain-test.cc@145 PS1, Line 145: buffer, buffer + expected_byte_size, expected_byte_size, &result); > Same as line 113. Done http://gerrit.cloudera.org:8080/#/c/11268/1/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/11268/1/testdata/data/README@192 PS1, Line 192: o rows wit > Please add a second row with different values. Done -- To view, visit http://gerrit.cloudera.org:8080/11268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If93394b035c64cf6fc5f37b54d29c034cc1f86e4 Gerrit-Change-Number: 11268 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Aug 2018 16:53:49 +0000 Gerrit-HasComments: Yes
