Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 )
Change subject: IMPALA-6373: Allow primitive type widening on parquet tables ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11268/2/be/src/exec/parquet-common.h File be/src/exec/parquet-common.h: http://gerrit.cloudera.org:8080/#/c/11268/2/be/src/exec/parquet-common.h@253 PS2, Line 253: inline int DecodeWithConversion(const uint8_t* buffer, const uint8_t* buffer_end, To* v) { > Thanks for the suggestion. I updated the code to remove code duplication as Thanks for doing the change! I think I will have to do some kind of type mapping related to https://gerrit.cloudera.org/#/c/11057/, but it will need more functionality than the one I advised here (the main problem is that millisec/microsec int64s will have to be treated differently during dictionary initialization). I am still thinking about the best way to do it. -- To view, visit http://gerrit.cloudera.org:8080/11268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If93394b035c64cf6fc5f37b54d29c034cc1f86e4 Gerrit-Change-Number: 11268 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 23 Aug 2018 12:32:08 +0000 Gerrit-HasComments: Yes
