Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11317 )

Change subject: IMPALA-7483: abort stuck impalad/catalogd on JVM deadlock
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11317/2/fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java
File fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java:

http://gerrit.cloudera.org:8080/#/c/11317/2/fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java@216
PS2, Line 216:         for (ThreadInfo thread : deadlockedThreads)  
LOG.error(thread.toString());
nit: in theory, given the threads are deadlocked, it should be guaranteed that 
the threads still exist when you call getThreadInfo() above. But, just in case, 
I think we should be extra defensive here and check 'thread' against null 
before calling thread.toString() here.


http://gerrit.cloudera.org:8080/#/c/11317/2/fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java@217
PS2, Line 217:         LOG.fatal("Aborting because of deadlocked threads in 
JVM.");
> Should we dump the entire thread stacks (not just the deadlocked ones) and
+1 for other thread stacks.



--
To view, visit http://gerrit.cloudera.org:8080/11317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If46f879e7ab9eeead0c6e9a09844e1356012898d
Gerrit-Change-Number: 11317
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Fri, 24 Aug 2018 22:48:36 +0000
Gerrit-HasComments: Yes

Reply via email to