Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11317 )
Change subject: IMPALA-7483: abort stuck impalad/catalogd on JVM deadlock ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11317/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11317/2//COMMIT_MSG@29 PS2, Line 29: I'm open to ideas about how to write an automated test for this and/or We could write a Java test that at least invokes the loop that checks for deadlocked threads. You could actually deadlock some threads, but I've found that calling .interrupt() on them is hopeless, so you'll have leaked them for the duration of the tests. That's maybe fine, but be sure to mark them as daemon threads. Or don't worry about it. For what it's worth, I found https://docs.oracle.com/javase/7/docs/technotes/guides/concurrency/threadPrimitiveDeprecation.html interesting. -- To view, visit http://gerrit.cloudera.org:8080/11317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If46f879e7ab9eeead0c6e9a09844e1356012898d Gerrit-Change-Number: 11317 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 23:15:50 +0000 Gerrit-HasComments: Yes
