Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 )
Change subject: IMPALA-7421. Static methods use wrong JNI call function ...................................................................... Patch Set 5: (3 comments) Had to make some changes when I rebased. http://gerrit.cloudera.org:8080/#/c/11181/5/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/11181/5/be/src/util/jni-util.h@438 PS5, Line 438: #define SPECIALIZE_PRIMITIVE_TO_VALUE(cpp_type, union_field) \ this stuff is new http://gerrit.cloudera.org:8080/#/c/11181/5/be/src/util/jni-util.h@487 PS5, Line 487: inline JniCall& JniCall::with_primitive_arg(T arg) { and this http://gerrit.cloudera.org:8080/#/c/11181/5/be/src/util/jni-util.cc File be/src/util/jni-util.cc: http://gerrit.cloudera.org:8080/#/c/11181/5/be/src/util/jni-util.cc@224 PS5, Line 224: .with_primitive_arg(FLAGS_jvm_deadlock_detector_interval_s) this changed a bit from the previous patch: i had to add this 'with_primtiive_arg' support, since this function now takes an argument -- To view, visit http://gerrit.cloudera.org:8080/11181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7cde6ca91613b63afe5307f4d819fb24cb17fd6 Gerrit-Change-Number: 11181 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 28 Aug 2018 02:47:39 +0000 Gerrit-HasComments: Yes
