Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 )
Change subject: IMPALA-7421. Static methods use wrong JNI call function ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Rebased and fixed the indentation issue. Carrying +2s. http://gerrit.cloudera.org:8080/#/c/11181/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11181/2//COMMIT_MSG@12 PS2, Line 12: -Xcheck:jni > mind filing a jira for this? Filed IMPALA-7489 http://gerrit.cloudera.org:8080/#/c/11181/3/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/11181/3/be/src/util/jni-util.h@126 PS3, Line 126: > nit: indentation off. Done -- To view, visit http://gerrit.cloudera.org:8080/11181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7cde6ca91613b63afe5307f4d819fb24cb17fd6 Gerrit-Change-Number: 11181 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 22:29:20 +0000 Gerrit-HasComments: Yes
