Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11350 )
Change subject: IMPALA-7446: enable missing buffer pool GC ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11350/2/be/src/runtime/mem-tracker-test.cc File be/src/runtime/mem-tracker-test.cc: http://gerrit.cloudera.org:8080/#/c/11350/2/be/src/runtime/mem-tracker-test.cc@386 PS2, Line 386: EXPECT_FALSE(t.TryConsume(1, MemLimit::SOFT)); > Is that necessary for the test? Not sure it's worth slowing down the test r good point -- To view, visit http://gerrit.cloudera.org:8080/11350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32400bda18a36f60cbe315fae715748d33677c10 Gerrit-Change-Number: 11350 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 30 Aug 2018 00:11:14 +0000 Gerrit-HasComments: Yes
