Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11350 )
Change subject: IMPALA-7446: enable missing buffer pool GC ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11350/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11350/3//COMMIT_MSG@10 PS3, Line 10: can spill why is that? isn't the memory available for BP buffers regardless of whether it's in the buffer pool free list or the system? http://gerrit.cloudera.org:8080/#/c/11350/3//COMMIT_MSG@10 PS3, Line 10: OOM how did the OOM (non spillable allocation failures) go unnoticed for so long? what tests are missing (besides unit test)? -- To view, visit http://gerrit.cloudera.org:8080/11350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32400bda18a36f60cbe315fae715748d33677c10 Gerrit-Change-Number: 11350 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Aug 2018 19:05:16 +0000 Gerrit-HasComments: Yes
