Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11363 )

Change subject: IMPALA-7499: build against CDH Kudu
......................................................................


Patch Set 1:

(16 comments)

http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@72
PS1, Line 72:
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@73
PS1, Line 73:
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@74
PS1, Line 74:
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@74
PS1, Line 74:
flake8: E241 multiple spaces after ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@75
PS1, Line 75:
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@75
PS1, Line 75:
flake8: E241 multiple spaces after ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@76
PS1, Line 76:
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@79
PS1, Line 79:
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@106
PS1, Line 106: lsb_release_cache = None
flake8: E305 expected 2 blank lines after class or function definition, found 1


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@107
PS1, Line 107: def get_os_version():
flake8: E302 expected 2 blank lines, found 0


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@121
PS1, Line 121: def try_get_toolchain_platform_label():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@129
PS1, Line 129: def try_get_cdh_platform_label():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@134
PS1, Line 134: e
flake8: E722 do not use bare except'


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@137
PS1, Line 137: def get_toolchain_platform_label(release=None):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@150
PS1, Line 150: def get_cdh_platform_label():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/11363/1/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:

http://gerrit.cloudera.org:8080/#/c/11363/1/infra/python/bootstrap_virtualenv.py@277
PS1, Line 277: k
flake8: F821 undefined name 'kudu_base_dir'



--
To view, visit http://gerrit.cloudera.org:8080/11363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6e1048438b6d09a1b38c58371d6212bb6dcc06c
Gerrit-Change-Number: 11363
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 30 Aug 2018 20:11:56 +0000
Gerrit-HasComments: Yes

Reply via email to