Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11363 )
Change subject: IMPALA-7499: build against CDH Kudu ...................................................................... Patch Set 2: (22 comments) http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@19 PS1, Line 19: # The purpose of this script is to download prebuilt binaries and jar files to satisfy the : # third-party dependencies for Impala. The script checks for the presence of IMPALA_HOME : # and IMPALA_TOOLCHAIN. IMPALA_HOME indicates that the environment is correctly setup and : # that we can deduce the version settings of the dependencies from the environment. : # IMPALA_TOOLCHAIN indicates the location where the prebuilt artifacts should be extracted : # to. If DOWNLOAD_CDH_COMPONENTS is set to true, this script will also download and : # extract the CDH components (i.e. Hadoop, Hive, HBase and Sentry) into : # CDH_COMPONENTS_HOME. > Could you update this to include KUDU_IS_SUPPORTED and USE_CDH_KUDU as they Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@71 PS1, Line 71: OsMapping("suselinux11", "ec2-package-sles-11", None), > add a doc here about what this maps to and from? Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@72 PS1, Line 72: ( > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@73 PS1, Line 73: ( > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@74 PS1, Line 74: " > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@74 PS1, Line 74: c > flake8: E241 multiple spaces after ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@75 PS1, Line 75: c > flake8: E241 multiple spaces after ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@75 PS1, Line 75: " > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@76 PS1, Line 76: ( > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@79 PS1, Line 79: > flake8: E203 whitespace before ':' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@106 PS1, Line 106: 'toolchain' and 'cdh' labels. Return None if not found. > flake8: E305 expected 2 blank lines after class or function definition, fou Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@107 PS1, Line 107: """ > Please add pydoc here? Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@107 PS1, Line 107: """ > flake8: E302 expected 2 blank lines, found 0 Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@121 PS1, Line 121: 'release' can be provided to override the underlying OS version. > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@129 PS1, Line 129: # Only need to check against the major release if RHEL or CentOS > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@134 PS1, Line 134: > flake8: E722 do not use bare except' Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@137 PS1, Line 137: return mapping > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@150 PS1, Line 150: try: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@154 PS1, Line 154: if attempt == NUM_ATTEMPTS: : raise : logging.error("Download failed; retrying after sleep: " + str(e)) : time.sle > This code is identical to lines 141-145. I think it probably makes sense to Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@475 PS1, Line 475: > This is just: if ...: packages += Package["kudu"] Done http://gerrit.cloudera.org:8080/#/c/11363/1/bin/bootstrap_toolchain.py@501 PS1, Line 501: > This is just: Done http://gerrit.cloudera.org:8080/#/c/11363/1/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/11363/1/infra/python/bootstrap_virtualenv.py@277 PS1, Line 277: > flake8: F821 undefined name 'kudu_base_dir' Done -- To view, visit http://gerrit.cloudera.org:8080/11363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6e1048438b6d09a1b38c58371d6212bb6dcc06c Gerrit-Change-Number: 11363 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 30 Aug 2018 22:40:37 +0000 Gerrit-HasComments: Yes
