Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11314 )

Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET 
OWNER
......................................................................


Patch Set 16:

(22 comments)

http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py
File tests/authorization/test_owner_privileges.py:

http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@29
PS16, Line 29: from tests.util.calculation_util import get_random_id
flake8: F401 'tests.util.calculation_util.get_random_id' imported but unused


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@30
PS16, Line 30: from tests.verifiers.metric_verifier import MetricVerifier
flake8: F401 'tests.verifiers.metric_verifier.MetricVerifier' imported but 
unused


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@45
PS16, Line 45: class TestObject():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@49
PS16, Line 49: d
flake8: E301 expected 1 blank line, found 0


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@69
PS16, Line 69: class TestOwnerPrivileges(CustomClusterTestSuite, 
ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@120
PS16, Line 120: e
flake8: F841 local variable 'e' is assigned to but never used


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@139
PS16, Line 139: "
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@153
PS16, Line 153: "
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@271
PS16, Line 271: l
flake8: E501 line too long (95 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@275
PS16, Line 275: =
flake8: E711 comparison to None should be 'if cond is None:'


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@291
PS16, Line 291: t
flake8: F821 undefined name 'true'


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@291
PS16, Line 291: ;
flake8: E703 statement ends with a semicolon


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@292
PS16, Line 292: e
flake8: F841 local variable 'e' is assigned to but never used


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@305
PS16, Line 305: "
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@319
PS16, Line 319: "
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@347
PS16, Line 347: t
flake8: E501 line too long (96 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@353
PS16, Line 353: r
flake8: E501 line too long (95 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@360
PS16, Line 360: s
flake8: E501 line too long (97 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@372
PS16, Line 372: "
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@386
PS16, Line 386: "
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@415
PS16, Line 415: t
flake8: E501 line too long (96 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/11314/16/tests/authorization/test_owner_privileges.py@421
PS16, Line 421: s
flake8: E501 line too long (97 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/11314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e09332e007ed5aa6a0840683c879a8295c3d2b0
Gerrit-Change-Number: 11314
Gerrit-PatchSet: 16
Gerrit-Owner: Adam Holley <[email protected]>
Gerrit-Reviewer: Adam Holley <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sun, 02 Sep 2018 03:12:30 +0000
Gerrit-HasComments: Yes

Reply via email to