Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 )
Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER ...................................................................... Patch Set 17: (22 comments) http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@29 PS17, Line 29: from tests.util.calculation_util import get_random_id > flake8: F401 'tests.util.calculation_util.get_random_id' imported but unuse Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@30 PS17, Line 30: from tests.verifiers.metric_verifier import MetricVerifier > flake8: F401 'tests.verifiers.metric_verifier.MetricVerifier' imported but Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@45 PS17, Line 45: class TestObject(): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@49 PS17, Line 49: d > flake8: E301 expected 1 blank line, found 0 Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@69 PS17, Line 69: class TestOwnerPrivileges(CustomClusterTestSuite, ImpalaTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@120 PS17, Line 120: e > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@139 PS17, Line 139: " > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@153 PS17, Line 153: " > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@271 PS17, Line 271: l > flake8: E501 line too long (95 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@275 PS17, Line 275: = > flake8: E711 comparison to None should be 'if cond is None:' Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@291 PS17, Line 291: t > flake8: F821 undefined name 'true' Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@291 PS17, Line 291: ; > flake8: E703 statement ends with a semicolon Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@292 PS17, Line 292: e > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@305 PS17, Line 305: " > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@319 PS17, Line 319: " > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@347 PS17, Line 347: t > flake8: E501 line too long (96 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@353 PS17, Line 353: r > flake8: E501 line too long (95 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@360 PS17, Line 360: s > flake8: E501 line too long (97 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@372 PS17, Line 372: " > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@386 PS17, Line 386: " > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@415 PS17, Line 415: t > flake8: E501 line too long (96 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/11314/17/tests/authorization/test_owner_privileges.py@421 PS17, Line 421: s > flake8: E501 line too long (97 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/11314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e09332e007ed5aa6a0840683c879a8295c3d2b0 Gerrit-Change-Number: 11314 Gerrit-PatchSet: 17 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 02 Sep 2018 03:43:29 +0000 Gerrit-HasComments: Yes
