Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 )
Change subject: IMPALA-6568 add missing Query Compilation section to profiles. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11387/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11387/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1167 PS1, Line 1167: timeline.markEvent("Planning finished"); Did you consider refactoring this function to move the guts of it into a new function? It seems a little odd to me that many of the results now have a timeline which doesn't include "Planning finished" - in particular EXPLAIN goes through all of the planning. http://gerrit.cloudera.org:8080/#/c/11387/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/11387/1/tests/query_test/test_observability.py@251 PS1, Line 251: found = False : for line in runtime_profile.splitlines(): : match = re.search(regex, line) : if match is not None: : found = True maybe just: assert any(re.search(regex, line) for line in runtime_profiles.splitlines()) -- To view, visit http://gerrit.cloudera.org:8080/11387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I869eaeb4be4291b6b938f91847f624c76ec90ea5 Gerrit-Change-Number: 11387 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 05 Sep 2018 00:32:51 +0000 Gerrit-HasComments: Yes
