Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 )
Change subject: WIP: IMPALA-6568 add missing Query Compilation section to profiles. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11387/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11387/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1167 PS1, Line 1167: FeFsTable hdfsTable = (FeFsTable) insertStmt.getTargetTable(); > I did not consider this, but I will now. hmm, but even with the earlier 'planning finished', statements like LOAD DATA don't have the 'Planning finished' in the timeline. I was thinking of taking the entirety of the function body into a new 'doCreateExecStatement', and have the wrapper function create a timeline and be responsible for setting it into the result, sort of similar to the refactor I started here: https://gerrit.cloudera.org/c/11388/2/fe/src/main/java/org/apache/impala/service/Frontend.java#1024 Would that allow you to avoid the repeated calls to result.setTimeline everywhere? -- To view, visit http://gerrit.cloudera.org:8080/11387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I869eaeb4be4291b6b938f91847f624c76ec90ea5 Gerrit-Change-Number: 11387 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 05 Sep 2018 19:39:44 +0000 Gerrit-HasComments: Yes
